-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[Docs site] Add sidebar filters to ResourcesBySelector + top-level /resources page #25618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
pedrosousa
reviewed
Oct 13, 2025
pedrosousa
reviewed
Oct 13, 2025
src/content/docs/cache/how-to/cache-rules/examples/browser-cache-ttl.mdx
Show resolved
Hide resolved
pedrosousa
reviewed
Oct 13, 2025
pedrosousa
reviewed
Oct 13, 2025
pedrosousa
reviewed
Oct 13, 2025
Co-authored-by: Pedro Sousa <[email protected]>
Co-authored-by: Pedro Sousa <[email protected]>
Co-authored-by: Pedro Sousa <[email protected]>
pedrosousa
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds a new
filterPlacementparameter to theResourcesBySelectorcomponent, that then allows us to add a giant, filterable grid to/resources.Why it's needed
To help highlight the more in-depth resources that we offer that sometimes get hidden. We've also experimented with listing these individually in the past (like with
learning-paths), but that feels to narrow to be helpful to folks looking for our resources. They're coming with a problem in mind, not a specific type of resource.(this also did some cleanup for how we reference
productvalues in our docs, and should help with the maintenance around them)How to review
.mdxfiles changed. These should only be for theproductsfrontmatter values and -- since we auto-validate them now -- any errors would fail the build. Might be a few that need to be tweaked.... but think this'll come up organically.Sub-tasks
productsfrontmatter values to be references that then grab the appropriate "pretty" name of the product (similar to how we handle for changelog entries).